summaryrefslogtreecommitdiff
path: root/plugins/kolab_addressbook
diff options
context:
space:
mode:
authorAleksander Machniak <machniak@kolabsys.com>2014-11-21 09:03:18 (GMT)
committerAleksander Machniak <machniak@kolabsys.com>2014-11-21 09:03:18 (GMT)
commitac4f6e75622c76e32d6a34fcbfb7b57ead18fd92 (patch)
tree7004e44eff67616b8cbc306c8652809f885b7b8d /plugins/kolab_addressbook
parent5738a7a7eca4256f39b279918d77f354cb9d4e28 (diff)
downloadroundcubemail-plugins-kolab-ac4f6e75622c76e32d6a34fcbfb7b57ead18fd92.tar.gz
Avoid unused variables (also fixed some bugs) found in static code analysis
Diffstat (limited to 'plugins/kolab_addressbook')
-rw-r--r--plugins/kolab_addressbook/kolab_addressbook.php4
-rw-r--r--plugins/kolab_addressbook/lib/rcube_kolab_contacts.php3
2 files changed, 1 insertions, 6 deletions
diff --git a/plugins/kolab_addressbook/kolab_addressbook.php b/plugins/kolab_addressbook/kolab_addressbook.php
index 9511e26..a78f7ca 100644
--- a/plugins/kolab_addressbook/kolab_addressbook.php
+++ b/plugins/kolab_addressbook/kolab_addressbook.php
@@ -102,7 +102,6 @@ class kolab_addressbook extends rcube_plugin
public function address_sources($p)
{
$abook_prio = $this->addressbook_prio();
- $undelete = $this->rc->config->get('undo_timeout');
// Disable all global address books
// Assumes that all non-kolab_addressbook sources are global
@@ -239,7 +238,6 @@ class kolab_addressbook extends rcube_plugin
*/
protected function addressbook_list_item($id, $source, &$jsdata, $search_mode = false)
{
- $folder = $this->folders[$id];
$current = rcube_utils::get_input_value('_source', rcube_utils::INPUT_GPC);
if (!$source['virtual']) {
@@ -433,7 +431,6 @@ class kolab_addressbook extends rcube_plugin
}
// convert to UTF8 and sort
- $names = array();
foreach ($folders as $folder) {
// create instance of rcube_contacts
$abook_id = $folder->id;
@@ -632,7 +629,6 @@ class kolab_addressbook extends rcube_plugin
$props['parent'] = kolab_storage::folder_id($kolab_folder->get_parent(), true);
$this->rc->output->show_message('kolab_addressbook.book'.$type.'d', 'confirmation');
- $this->rc->output->command('set_env', 'delimiter', $delimiter);
$this->rc->output->command('book_update', $props, kolab_storage::folder_id($prop['oldname'], true));
$this->rc->output->send('iframe');
}
diff --git a/plugins/kolab_addressbook/lib/rcube_kolab_contacts.php b/plugins/kolab_addressbook/lib/rcube_kolab_contacts.php
index 9b2c1e0..3b4a3f6 100644
--- a/plugins/kolab_addressbook/lib/rcube_kolab_contacts.php
+++ b/plugins/kolab_addressbook/lib/rcube_kolab_contacts.php
@@ -213,7 +213,6 @@ class rcube_kolab_contacts extends rcube_addressbook
*/
public function get_carddav_url()
{
- $url = null;
$rcmail = rcmail::get_instance();
if ($template = $rcmail->config->get('kolab_addressbook_carddav_url', null)) {
return strtr($template, array(
@@ -443,7 +442,7 @@ class rcube_kolab_contacts extends rcube_addressbook
$this->filter = array('fields' => $fields, 'value' => $value, 'mode' => $mode, 'ids' => array());
// search by iterating over all records in dataset
- foreach ($this->dataset as $i => $record) {
+ foreach ($this->dataset as $record) {
$contact = $this->_to_rcube_contact($record);
$id = $contact['ID'];