summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnatoliy Belsky <ab@php.net>2012-04-10 09:03:41 (GMT)
committerAnatoliy Belsky <ab@php.net>2012-04-10 09:03:41 (GMT)
commitd89b65f98503bbe99ee7810a97b2c0a16da2651c (patch)
tree29b243e948ba2f6812e5b221ddec897f63bc8869
parent4ff55e646ab3450e06054b65a351082efe43e473 (diff)
downloadphp-d89b65f98503bbe99ee7810a97b2c0a16da2651c.tar.gz
Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
The behaviour on windows is to select an arbitrary timezone from the current system settings. This gives no chance to hardcode the timezone name, for instance for UTC+1 it could choose from the multiple names like Europe/Berlin or Europe/Paris . For this reason the test is parametrized so there is no hardcoded timezone data. The original test made to be skipped on windows and a duplicate was made for windows.
-rw-r--r--ext/date/tests/date_default_timezone_get-1-win32.phpt24
-rw-r--r--ext/date/tests/date_default_timezone_get-1.phpt4
2 files changed, 28 insertions, 0 deletions
diff --git a/ext/date/tests/date_default_timezone_get-1-win32.phpt b/ext/date/tests/date_default_timezone_get-1-win32.phpt
new file mode 100644
index 0000000..a12418f
--- /dev/null
+++ b/ext/date/tests/date_default_timezone_get-1-win32.phpt
@@ -0,0 +1,24 @@
+--TEST--
+date_default_timezone_get() function [1]
+--SKIPIF--
+<?php
+ if(substr(PHP_OS, 0, 3) != 'WIN') die("skip skip on non windows");
+?>
+--INI--
+date.timezone=
+--FILE--
+<?php
+ putenv('TZ=');
+ echo date_default_timezone_get(), "\n";
+ echo date('e'), "\n";
+ /* The behaviour on windows is to select an arbitrary timezone name from the current system settings.
+ This gives no chance to hardcode the timezone name, for instance for UTC+1 it could choose
+ from the multiple names like Europe/Berlin or Europe/Paris . For this reason the test is
+ parametrized so there is no hardcoded timezone data.*/
+?>
+--EXPECTF--
+Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected '%s' for '%s' instead in %sdate_default_timezone_get-1-win32.php on line 3
+%s
+
+Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected '%s' for '%s' instead in %sdate_default_timezone_get-1-win32.php on line 4
+%s
diff --git a/ext/date/tests/date_default_timezone_get-1.phpt b/ext/date/tests/date_default_timezone_get-1.phpt
index 383394a..5d17a25 100644
--- a/ext/date/tests/date_default_timezone_get-1.phpt
+++ b/ext/date/tests/date_default_timezone_get-1.phpt
@@ -1,5 +1,9 @@
--TEST--
date_default_timezone_get() function [1]
+--SKIPIF--
+<?php
+ if(substr(PHP_OS, 0, 3) == 'WIN') die("skip on windows");
+?>
--INI--
date.timezone=
--FILE--